buffer: throw on invalid encoding in Buffer.from

Refs: nodejs#54533 PR-URL: nodejs#54586
nxtedition · Aug 27, 2024 · 9d335ca · 9d335ca
1 parent c00ea01
commit 9d335ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -476,7 +476,7 @@ function createFromString(string, ops, length = ops.byteLength(string)) {
 
 function fromString(string, encoding) {
   let ops;
-  if (!encoding || encoding === 'utf8' || typeof encoding !== 'string') {
+  if (encoding == null || encoding === 'utf8') {
     ops = encodingOps.utf8;
   } else {
     ops = getEncodingOps(encoding);

diff --git a/test/parallel/test-buffer-from.js b/test/parallel/test-buffer-from.js
@@ -140,5 +140,8 @@ throws(() => {
   })
 );
 
-// Invalid encoding is allowed
-Buffer.from('asd', 1);
+throws(() => {
+  Buffer.from('asd', 1);
+}, {
+  code: 'ERR_UNKNOWN_ENCODING'
+});