Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query_params to the folders.list(..) method #488

Closed
neilberget opened this issue Sep 12, 2024 · 1 comment · Fixed by #492
Closed

Add query_params to the folders.list(..) method #488

neilberget opened this issue Sep 12, 2024 · 1 comment · Fixed by #492
Assignees

Comments

@neilberget
Copy link

There is no way to retrieve a second page of folders since the list method in Folders only takes the identifier parameter.

If the query_params argument is added (for example https://github.com/nylas/nylas-ruby/blob/main/lib/nylas/resources/messages.rb#L30 we'd be able to pass in a cursor for pagination.

We have worked around it by building the api call ourself but would help clean things up if this was made to be consistent with the other list methods.

I do see the cursor is already being returned, so only allowing it to be passed in via query_params should solve the issue.

@mrashed-dev
Copy link
Contributor

@neilberget Thanks for posting, will add this!

@mrashed-dev mrashed-dev self-assigned this Sep 23, 2024
mrashed-dev added a commit that referenced this issue Sep 24, 2024
mrashed-dev added a commit that referenced this issue Sep 24, 2024
# Changelog

## Added
* Added query support for folders (#492, #488)
* Added dependency on `ostruct` gem (#491, #489)
* Enable SDK to reattach large files to messages on retry (#487)

## Changed
* Downgraded `rest-client` to `2.0` for better compatibility (#490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants