Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen rest-client version #490

Merged

Conversation

lekemula
Copy link
Contributor

@lekemula lekemula commented Sep 17, 2024

Description

Hi there,

In my current organisation, we are trying to upgrade to nylas API v3, however nylas 6.x Ruby SDK conflicts with one of our chargebee-ruby sub-dependency:

chargebee (2.43.0)
      rest-client (>= 1.8, <= 2.0.2)
nylas (6.1.1)
  	  rest-client (~> 2.1, < 3.0) 

While there's already a PR to upgrade chargebee usage of rest-client, chargebee/chargebee-ruby#83, we're unsure whether that will land on time, so we were wondering whether for the time being we could loosen up the version on your side?

When running the CI against rest-client 2.0.0 there seems to be ✅. Do you see any repercussions against doing that?

❯ bi
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using rest-client 2.0.0 (was 2.1.0)
Bundle complete! 12 Gemfile dependencies, 47 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
❯ be rspec
....................................................................................................................................................................

Finished in 0.05607 seconds (files took 0.39409 seconds to load)
164 examples, 0 failures

This is currently blocking us from migrating to Nylas API v3.

Thanks in advance for your help.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@lekemula lekemula marked this pull request as ready for review September 17, 2024 14:41
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (8490435) to head (250dd9e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   99.85%   99.56%   -0.29%     
==========================================
  Files          24       24              
  Lines         681      694      +13     
==========================================
+ Hits          680      691      +11     
- Misses          1        3       +2     
Flag Coverage Δ
99.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekemula Looking at the changelog from 2.0 -> 2.1 the changes look like they are not critical to how the SDK uses them and as long as the CIs passed then we should be good! Thanks and will have this in the next release.

@mrashed-dev mrashed-dev merged commit 8dd54b2 into nylas:main Sep 23, 2024
5 of 7 checks passed
@mrashed-dev mrashed-dev mentioned this pull request Sep 24, 2024
mrashed-dev added a commit that referenced this pull request Sep 24, 2024
# Changelog

## Added
* Added query support for folders (#492, #488)
* Added dependency on `ostruct` gem (#491, #489)
* Enable SDK to reattach large files to messages on retry (#487)

## Changed
* Downgraded `rest-client` to `2.0` for better compatibility (#490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants