Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure Drupal file paths in Nginx Dockerfile #11

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

esolitos
Copy link
Contributor

@esolitos esolitos commented Jun 5, 2024

What

This change sets up the default environment variables and file paths for a Drupal application running in an Nginx container. It creates a symlink to the default location where the persistent files are stored, which is usually done at runtime by calling the makefiles script. This change ensures that the file paths are properly configured without having to run the script every time the container is started.

Why

Currently we create the symlink using the make -f /usr/local/bin/actions.mk init command when we start the container, which calls the init script and in our scenario does the same thing as we are doing here by calling the files_link command.

This is not great as it requires an additional step at deploy time, and since we always use the same setup we can hardcode this at build time instead of at run time.

Additional info

This is the nginx companion of previous PRs: #7

This change sets up the default environment variables and file paths for a Drupal
application running in an Nginx container. It creates a symlink to the default
location where the persistent files are stored, which is usually done at runtime
by calling the makefiles script. This change ensures that the file paths are
properly configured without having to run the script every time the container
is started.
@esolitos esolitos requested a review from a team June 5, 2024 08:48
@esolitos esolitos merged commit 00bab4e into 1.x Jun 5, 2024
@esolitos esolitos deleted the default-drupal-dockerfile-configuration branch June 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants