✨ Add symlink creation for PHP storage directory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a symlink for the PHP storage directory to avoid running script on container start. Also ensure directory ownership by webserver user.
reuse the DRUPAL_FILES_DIR instead of appending "files" to DRUPAL_SITE_DIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/tmp/phppath exists to use for twig compilation.Why
Currently we create the symlink using the
make -f /usr/local/bin/actions.mk init-drupalcommand when we start the container, which in our scenario does the same thing as we are doing here by calling thefiles_linkcommand (from the init_drupal).This is not great as it requires an additional step at deploy time, and since we always use the same setup we can hardcode this at build time instead of at run time.
Additional info
https://github.com/nymedia/akademika_d8/blob/develop/.github/workflows/container-images.yml#L19C1-L20C1
https://github.com/nymedia/github-shared-workflows/blob/1.x/.github/workflows/build-drupal-container-images.yml