Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all const duration values more explicit. #333

Closed
jstuczyn opened this issue Sep 10, 2020 · 0 comments · Fixed by #391
Closed

Make all const duration values more explicit. #333

jstuczyn opened this issue Sep 10, 2020 · 0 comments · Fixed by #391
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@jstuczyn
Copy link
Contributor

Currently all default config duration values are defined in u64 and are treated as if they were milliseconds. This could be made more explicit now that Duration can be constructed in compile time. So instead of
const DEFAULT_MESSAGE_STREAM_AVERAGE_DELAY: u64 = 500;
we could have:
const DEFAULT_MESSAGE_STREAM_AVERAGE_DELAY: Duration = Duration::from_millis(500);

@jstuczyn jstuczyn added enhancement New feature or request good first issue Good for newcomers labels Sep 10, 2020
@jstuczyn jstuczyn added this to the 0.9.0 milestone Sep 10, 2020
@jstuczyn jstuczyn self-assigned this Oct 14, 2020
@mmsinclair mmsinclair moved this to Done in Core systems May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant