Fix target_train_data_fraction overriding pretrain_data_fraction #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug described in issue #1066 ("Results with pretrain_data_fraction args").
This PR...
Task
object (_instance_generators
) to store instance generators with the appropriate phase-specific data fraction settings.get_instance_generator
and setterset_instance_generator
, toTask
to access the_instance_generators
.Task
's that an exception is raised when training instance generator is requested without specifying the phase (because phase determines data fraction).Validation: the config provided in issue #1066 was run with these code changes. Results logged for the task (MNLI) using a pretraining data fraction were more in line with expectation: after 25k steps training accuracy was ~100%, while val and test accuracy were ~75%.