Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target_train_data_fraction overriding pretrain_data_fraction #1070

Merged
merged 10 commits into from
Apr 23, 2020
Merged

Fix target_train_data_fraction overriding pretrain_data_fraction #1070

merged 10 commits into from
Apr 23, 2020

Commits on Apr 16, 2020

  1. add private instance generator field to Task w/ getter and setter

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    fff429c View commit details
    Browse the repository at this point in the history

  2. update build_tasks to use new instance generator Task field setter

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    348b921 View commit details
    Browse the repository at this point in the history

  3. update trainer to get phase-appropriate instance generators

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    df68216 View commit details
    Browse the repository at this point in the history

  4. update evaluate to use new Task instance generator getter

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    ea90c29 View commit details
    Browse the repository at this point in the history

  5. update pred writing task to use new instance generator getter/setter

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    810ed97 View commit details
    Browse the repository at this point in the history

  6. add tests for new Task instance generator functionality

    @pyeres
    pyeres committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    98243e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. rename var: dataset_name -> split_name

    @pyeres
    pyeres committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    c5d6822 View commit details
    Browse the repository at this point in the history

  2. drop stray BucketIterator comment

    @pyeres
    pyeres committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a44d4d5 View commit details
    Browse the repository at this point in the history

  3. rename to correct types: generator -> iterable

    @pyeres
    pyeres committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    72a5bfe View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into py/fix_data_fraction

    @pyeres
    pyeres committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    aa1666a View commit details
    Browse the repository at this point in the history