Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error checking with missing environment variables on start up #4

Closed
MartinMinkov opened this issue Feb 14, 2023 · 1 comment
Assignees

Comments

@MartinMinkov
Copy link
Contributor

No description provided.

@MartinMinkov MartinMinkov self-assigned this Feb 14, 2023
@nicc
Copy link
Collaborator

nicc commented Feb 15, 2023

Indirectly Irresponsible Individual: @bkase

MartinMinkov added a commit that referenced this issue Feb 24, 2023
## Description
This PR introduces improved error handling for environment variables and
better compatibility checks for the Postgres schema. The changes
include:

1. Checking the Postgres schema compatibility with the tables the server
uses on startup.
2. Adding a new environment variable, ENABLE_LOGGING, allows users to
specify if they want any logging. If logging is enabled, it will direct
to stdout first. If JAEGER_LOGGING is enabled, the environment variables
related to that functionality will also be checked.
3. Adding POST to the allowed CORS methods to support GraphQL.
4. Minor refactors to improve code quality and maintainability.

Addresses #4 #18 

## Impact:
These changes will improve the reliability and stability of the server.
The improved error handling for environment variables will catch
potential issues early on and prevent the server from starting with
incorrect configurations. The added compatibility check for the Postgres
schema will ensure that the server uses the correct tables, improving
data accuracy and consistency. Adding the ENABLE_LOGGING environment
variable will give users more control over logging and provide better
visibility into the server's operation. Adding POST to the allowed CORS
methods will support GraphQL and improve the user experience. The minor
refactor will improve the maintainability of the code and make future
development easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants