-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable error handling #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Overall LGTM but left some comments.
Also it seems that DB connection string and schema validity is checked for the first host in multi-host connection string provided. |
331faaa
to
a79b6c3
Compare
Multi-host checking seems to be more complicated; I will address this in another PR. #29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- LGTM, left another comment but approved.
- Thank you.
2c4b761
to
5616fa2
Compare
Description
This PR introduces improved error handling for environment variables and better compatibility checks for the Postgres schema. The changes include:
Addresses #4 #18
Impact:
These changes will improve the reliability and stability of the server. The improved error handling for environment variables will catch potential issues early on and prevent the server from starting with incorrect configurations. The added compatibility check for the Postgres schema will ensure that the server uses the correct tables, improving data accuracy and consistency. Adding the ENABLE_LOGGING environment variable will give users more control over logging and provide better visibility into the server's operation. Adding POST to the allowed CORS methods will support GraphQL and improve the user experience. The minor refactor will improve the maintainability of the code and make future development easier.