Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deprecated assert* to require* in o1js precondition APIs #749

Open
mitschabaude opened this issue Nov 27, 2023 · 11 comments
Open

Rename deprecated assert* to require* in o1js precondition APIs #749

mitschabaude opened this issue Nov 27, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mitschabaude
Copy link
Contributor

adapt docs to o1-labs/o1js#1247

@mitschabaude mitschabaude transferred this issue from o1-labs/o1js Nov 27, 2023
@mitschabaude
Copy link
Contributor Author

cc @LuffySama-Dev

@mitschabaude mitschabaude added the good first issue Good for newcomers label Nov 27, 2023
@LuffySama-Dev
Copy link
Contributor

cc @LuffySama-Dev

Hi Gregor,
Thanks for assigning.
I will get started with it 🙋.

Thank You 😄

@LuffySama-Dev
Copy link
Contributor

Hi @mitschabaude ,

I am facing some issue when I am trying to install the o1js, as new version of o1js package has not been released yet, I am unable to install it locally via npm and can't test the examples.

  1. Is there any other way which I can try this?
  2. I need to update the docs and examples only right ?
  3. Will it be okay if the examples have the latest o1js version installed in them ?

Thank You 😃

@mitschabaude
Copy link
Contributor Author

@LuffySama-Dev good question! you can install o1js from a local folder like npm i ../o1js and just not commit that change yet. and then when it's released we update your PR to use the latest version and merge it?

@LuffySama-Dev
Copy link
Contributor

Awesome !!

Will make the changes and update here once ready 🙌🙌

@garwalsh garwalsh added to-burn and removed to-burn labels Nov 30, 2023
@ymekuria
Copy link
Contributor

@LuffySama-Dev FYI, the new o1js version that has these changes has been released.

@LuffySama-Dev
Copy link
Contributor

Hi @ymekuria ,

Thanks for letting me know. I will get started with it.

@LuffySama-Dev
Copy link
Contributor

Hi @mitschabaude , @ymekuria , @barriebyron

I have raised the Pull request number #786 .
Can you please review it ?

Thanks

ymekuria added a commit that referenced this issue Jan 4, 2024
#749  Rename deprecated assert* to require* in o1js precondition APIs
@barriebyron
Copy link
Contributor

barriebyron commented Feb 23, 2024

thanks @LuffySama-Dev for this good work! We are now looking at the two "unnumbered easy-to-skip" tutorials that need the same love
https://docs.minaprotocol.com/zkapps/tutorials/anonymous-message-board
https://docs.minaprotocol.com/zkapps/tutorials/interacting-with-zkapps-server-side

Would you be up for working with me on these?

@LuffySama-Dev
Copy link
Contributor

Hi @barriebyron ,

Yes sure. I would love too work on it.

Thank You 😊

@LuffySama-Dev
Copy link
Contributor

Hi @barriebyron ,

Let me know when we can start ?
Also, I am not sure what to do 😅😅.
So, can you please help to explain?

Thank You 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants