Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#749 Rename deprecated assert* to require* in o1js precondition APIs #786

Merged
merged 14 commits into from
Jan 4, 2024

Conversation

LuffySama-Dev
Copy link
Contributor

Hi @mitschabaude , @ymekuria , @barriebyron ,

Please find the below changes that I have made to close the issue number #749 .

Changes Made:

  • Renamed deprecated assert* with require*
  • Updated the tutorials package.json to use latest o1js version

Files/Tutorials changed:

  • Examples from 01 to 11 and Interacting with zkapps are updated
  • Tutorials from 01 to Interacting with zkapps are updated
  • Other documentations where also updated

Files/Tutorials Pending to be updated:

  • Facing issue with example 06-offchain-storage. I have updated it locally but the offchain storage zkApp contract's package.json has peer dependency to version of "experimental-offchain-zkapp-storage". So I think we need to update it so, I will need your guidance over here on what to change and how. cc: @mitschabaude
  • Anonymous message board has not used assert for state so no changes made but, I have locally updated it's package.json to use latest o1js version. My question is should I commit it or not ?
  • o1js-reference is the only folder I am yet to go through so will make changes to it soon.

Thank You
Luffy 😃

@LuffySama-Dev LuffySama-Dev requested a review from a team as a code owner December 20, 2023 07:19
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 8:29am

Copy link

vercel bot commented Dec 20, 2023

@LuffySama-Dev is attempting to deploy a commit to the o1labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @LuffySama-Dev! Could you update the o1js version to 0.15.1 in all the tutorials?

examples/zkapps/01-hello-world/package.json Outdated Show resolved Hide resolved
examples/zkapps/04-zkapp-browser-ui/contracts/package.json Outdated Show resolved Hide resolved
examples/zkapps/05-common-types-and-functions/package.json Outdated Show resolved Hide resolved
examples/zkapps/07-oracles/contracts/package.json Outdated Show resolved Hide resolved
examples/zkapps/08-custom-tokens/package.json Outdated Show resolved Hide resolved
examples/zkapps/09-recursion/package.json Outdated Show resolved Hide resolved
examples/zkapps/10-account-updates/package.json Outdated Show resolved Hide resolved
examples/zkapps/11-advanced-account-updates/package.json Outdated Show resolved Hide resolved
@LuffySama-Dev
Copy link
Contributor Author

Hi @ymekuria ,

Yes sure!

Thanks

@LuffySama-Dev
Copy link
Contributor Author

Hi @ymekuria ,

I have made changes as requested.

Thanks 😃

Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuffySama-Dev !

Co-authored-by: Yoni Mekuria <ymekuria@gmail.com>
@ymekuria ymekuria merged commit 823737b into o1-labs:main Jan 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants