Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/zkapps/tutorials/01-hello-world.mdx #788

Merged

Conversation

Violet-Bora-Lee
Copy link
Contributor

Add information about the error

image

Change the deprecated method assertEquals to requireEquals

  • and update the related docs and docs
    image

Update the log

image

P.S. requireEquals seems to override assertEquals, but the corresponding error handling code remains the same.
image

@Violet-Bora-Lee Violet-Bora-Lee requested a review from a team as a code owner January 2, 2024 21:36
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:14pm

Copy link

vercel bot commented Jan 2, 2024

@Violet-Bora-Lee is attempting to deploy a commit to the o1labs Team on Vercel.

A member of the Team first needs to authorize it.

@Violet-Bora-Lee
Copy link
Contributor Author

Violet-Bora-Lee commented Jan 2, 2024

Oh, I think we can close this PR related to the deprecated method mentioned in the comment by merging #786.

@@ -162,6 +162,10 @@ In later tutorials, you learn how to interact with a smart contract from the bro

The `src/index.ts` file contains all of the exports you want to make available for consumption from outside your smart contract project, such as from a UI.

:::info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Violet-Bora-Lee I don't get this error message when I run through this tutorial.

What are the steps you are following to get the error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run an already-done tutorial, it won't show up. But it will show up if you run it from the top in turn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if I should include this information, but I stopped here to read the error and thought for a short time about what I did wrong with the error, so I thought it would be better to provide readers with information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it's too small an error, I'll take this part out and fix the pull request. 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me run through it as you did, and we'll include as appropriate, thank you!

Copy link
Contributor

@barriebyron barriebyron Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Violet-Bora-Lee, let's remove it since I followed step by step and did not encounter an error (Maybe your environment is different? or perhaps you ran the code before the tutorial explicitly stated to run code?

Thank you for your attention!

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Violet-Bora-Lee for your help! We appreciate your contributions

@barriebyron barriebyron merged commit 2825bfd into o1-labs:main Feb 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants