o1vm/riscv32im: adding programs for unit tests #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 72.04% 72.04% -0.01%
==========================================
Files 257 257
Lines 60690 60690
==========================================
- Hits 43723 43722 -1
- Misses 16967 16968 +1 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/o1vm/riscv32im/unit-test-asm
branch
3 times, most recently
from
935cd78 to
8e0a808
Compare
dannywillems
force-pushed
the
dw/o1vm/riscv32im/unit-test-asm
branch
3 times, most recently
from
33438ae to
77dc029
Compare
dannywillems
commented
Dec 5, 2024
| @@ -0,0 +1,17 @@ | |||
| .global _start | |||
|
|
|||
| exit_success: | |||
There was a problem hiding this comment.
Note: this is the semantics we do define in o1vm/riscv32im. It is not standard.
|
Solving conflicts. |
The idea is to move source files into a `src` directory at the same level than bin.
dannywillems
force-pushed
the
dw/o1vm/riscv32im/unit-test-asm
branch
from
77dc029 to
710eaba
Compare
|
Done. |
martyall
reviewed
Dec 5, 2024
Co-authored-by: Martin Allen <31280145+martyall@users.noreply.github.com>
Co-authored-by: Martin Allen <31280145+martyall@users.noreply.github.com>
Co-authored-by: Martin Allen <31280145+martyall@users.noreply.github.com>
martyall
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this set of changes is to introduce all the tooling that can be used by the developers working on the riscv32im to test the interpreter.
The set contains targets in the Makefile to compile the RISC-V GNU tool chain and some examples of basic programs written in the RISC-V 32IM ISA.
The test suite could contain actual functional tests, but also tests that should trigger exceptions or detect malicious prover/witness builders. The idea came out after witnessing these kinds of subtle changes.
The test related to o1vm/resources/programs/riscv32im/src/sll.S is commented for now because
luiis implemented late in the @svv232 PR train (see #2852), and trying to rebase on top of his branch cause conflicts.I would suggest having this set of changes on master, and start integrating instructions by instructions, with their corresponding unit test? No strong opinion, but it helps to shape the correctness of the slightly bigger program which is fibonnaci.