Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature list for SIG/Network #173

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Update feature list for SIG/Network #173

merged 4 commits into from
Apr 17, 2023

Conversation

lmbr-pip
Copy link
Contributor

Provide an updated list.

@lmbr-pip
Update feature list for SIG/Network
1193090 
Provide an updated list.

Signed-off-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
@lmbr-pip lmbr-pip requested review from chanmosq, a team and kberg0 April 13, 2023 16:54
chanmosq
chanmosq approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@chanmosq chanmosq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmbr-pip
Update releases/23.05.0/23050 feature list.md
c135488 
Signed-off-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
@lmbr-pip lmbr-pip requested a review from a team April 17, 2023 16:33
allisaurus
allisaurus reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@allisaurus allisaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggested changes for consistent tense across bullets

releases/23.05.0/23050 feature list.md Outdated Show resolved Hide resolved
releases/23.05.0/23050 feature list.md Outdated Show resolved Hide resolved
releases/23.05.0/23050 feature list.md Outdated Show resolved Hide resolved
lmbr-pip and others added 2 commits April 17, 2023 09:57
@lmbr-pip @allisaurus
Update releases/23.05.0/23050 feature list.md
c7e3380 
Co-authored-by: allisaurus <34254888+allisaurus@users.noreply.github.com>
Signed-off-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
@lmbr-pip @allisaurus
Apply suggestions from code review
cccfc68 
Co-authored-by: allisaurus <34254888+allisaurus@users.noreply.github.com>
Signed-off-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
kberg0
kberg0 approved these changes Apr 17, 2023
View reviewed changes
Copy link

@kberg0 kberg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Pip! 👍

tonybalandiuk
tonybalandiuk approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@tonybalandiuk tonybalandiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@tonybalandiuk tonybalandiuk merged commit b58c323 into o3de:main Apr 17, 2023
@lmbr-pip lmbr-pip mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisaurus allisaurus allisaurus left review comments

@tonybalandiuk tonybalandiuk tonybalandiuk approved these changes

@kberg0 kberg0 kberg0 approved these changes

@chanmosq chanmosq chanmosq approved these changes

@vincent6767 vincent6767 vincent6767 approved these changes

@SelfishOlex SelfishOlex SelfishOlex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmbr-pip @SelfishOlex @vincent6767 @allisaurus @chanmosq @kberg0 @tonybalandiuk