-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ovirt_vm_os_info #26
Conversation
Ah, ok, looks like we've both been working on the same thing! :) As per the commit comment its mostly copy/paste from your vnic_profile_info module anyway. Let me know if you want to create a PR anyway. |
@mnecas filter keys is nice, my only other question would be whether you want to add a line to the other modules referencing this one in the same PR? Otherwise LGTM! |
…e-collection into add_ovirt_vm_os_info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Add ovirt_vm_os_info as suggested in #24
Not sure if this is the best use case, but still wanted to add the PR where we could discuss it.
Right now the module return list of dictionaries which have attributes like name, architecture etc. in [1].
When I tried to get a list of all supported OS names it was so large list with all attributes that I did have to add filter_keys to filter the output. For example, the
large_icon
andsmall_icon
attributes are unnecessary for ansible (you can check them in [1] or /ovirt-engine/api/operatingsystems).To specific attributes like a name (you can check examples).
example of the output
Questions
[1] http://ovirt.github.io/ovirt-engine-api-model/master/#types/operating_system_info
@mwperina @dangel101 @snecklifter