Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operating system options #24

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update operating system options #24

merged 1 commit into from
Apr 16, 2020

Conversation

snecklifter
Copy link
Contributor

Updates various modules with the current (4.4) list.

other_linux_kernel_4
other_linux_s390x
other_s390x
rhcos_x64
rhel_3x64
rhel_6_9_plus_ppc64
rhel_7_s390x
rhel_8x64
rhel_atomic7x64
sles_12_s390x
ubuntu_16_04_s390x
windows_2016x64
windows_2019x64

Removed (incorrect and duplicate):

windows_2008r2x64

Updates various modules with the current (4.4) list.

other_linux_kernel_4
other_linux_s390x
other_s390x
rhcos_x64
rhel_3x64
rhel_6_9_plus_ppc64
rhel_7_s390x
rhel_8x64
rhel_atomic7x64
sles_12_s390x
ubuntu_16_04_s390x
windows_2016x64
windows_2019x64

Removed (incorrect and duplicate):

windows_2008r2x64
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mwperina
Copy link
Member

mwperina commented Apr 16, 2020

Can't we fetch supported OS versions from API? If so, wouldn't it be better to introduce ovirt_vm_os_info module to fetch it for specific engine instance and just refer in documentation to this module?

@mnecas @akrejcir

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 1149077 into oVirt:master Apr 16, 2020
mnecas added a commit that referenced this pull request Apr 16, 2020
@mnecas
Copy link
Member

mnecas commented Apr 16, 2020

Okay I'll check if it would be better to create ovirt_vm_os_info. Meanwhile will keep the and changes update if necessary.
Sorry about the revert my mistake.

@snecklifter
Copy link
Contributor Author

Okay I'll check if it would be better to create ovirt_vm_os_info. Meanwhile will keep the and changes update if necessary.
Sorry about the revert my mistake.

No probs, I did wonder if there was an easier way of maintaining the list... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants