ovirt dynamic plugin improvements #3
Conversation
- return None if stat.values is empty - allow insecure connection to the engine api - return from _get_hosts outside if-block - create connection while parse()'ing - change NAME according to collections convention - doc fixes - use shebang
| ovirt_insecure: | ||
| description: A boolean flag that indicates if the server TLS certificate and host name should be checked. | ||
| required: False | ||
| default: False |
There was a problem hiding this comment.
Connection expects a boolean for insecure.
As discussed in the original PR (ansible/ansible#49085 (comment)), this differs in the way insecure is handled in the other modules (e.g. ovirt_auth.py) where the value toggles to True in case insecure is None (default) and no CA is provided. I'd prefer to default to False - and possibly fail in the sdk - in case no CA is given and system CA's cannot verify a server.
plugins/inventory/ovirt.py
Outdated
| # ansible_host: devices["eth0"][0] | ||
| # Sample content of ovirt.yml | ||
| plugin: ovirt | ||
| ovirt_url: http://localhost/ovirt-engine/api |
There was a problem hiding this comment.
Can we add here https:// and ca_file parameter(and maybe comment how to get the CA file(wget https://engine/ovirt-engine/services/pki-resource?resource=ca-certificate&format=X509-PEM-CA)) so we provide the best practise in the examples?
|
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
SUMMARY
Improve oVirt dynamic inventory plugin based on comments in ansible/ansible#49085
ISSUE TYPE