Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect constructed strict option #38

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

AlanCoding
Copy link
Contributor

Tested locally by doing things like:

plugin: ovirt.ovirt.ovirt
ovirt_hostname_preference:
 - name
 - fqdn
strict: true
compose:
  ansible_host: '(devices.values() | list)[0][0] if devices else None'
  foobar: 'sefe or esfes'

so then it fails because "foobar" is nonsense, then

plugin: ovirt.ovirt.ovirt
ovirt_hostname_preference:
 - name
 - fqdn
strict: false
compose:
  ansible_host: '(devices.values() | list)[0][0] if devices else None'
  foobar: 'sefe or esfes'

works fine, because it ignores the nonsense entry.

This is also a pretty standard pattern in other inventory plugins. It's already in the options, because it comes from the constructed doc fragment.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@AlanCoding
Copy link
Contributor Author

ci test please

1 similar comment
@mnecas
Copy link
Member

mnecas commented May 8, 2020

ci test please

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit dc869e6 into oVirt:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants