Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt_remove_stale_lun: Retry "multipath -f" while removing the LUNs #382

Merged
merged 1 commit into from
Nov 15, 2021
Merged

ovirt_remove_stale_lun: Retry "multipath -f" while removing the LUNs #382

merged 1 commit into from
Nov 15, 2021

Conversation

nijinashok
Copy link
Contributor

There are possiblities that the vdsm might be holding the LUN
temporarily while we run "multipath -f". In these cases, the flushing
fails with error "map in use". Retry multipath -f (6 * 5 seconds) to
workaround this race condition.

RHBZ: https://bugzilla.redhat.com/2023224

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

There are possiblities that the vdsm might be holding the LUN
temporarily while we run "multipath -f". In these cases, the flushing
fails with error "map in use". Retry multipath -f (6 * 5 seconds) to
workaround this race condition.
@mnecas
Copy link
Member

mnecas commented Nov 15, 2021

Please review @vjuranek

@mnecas
Copy link
Member

mnecas commented Nov 15, 2021

ci add to whitelist

@vjuranek
Copy link
Member

LGTM, thanks @nijinashok !

@mnecas mnecas merged commit add1f91 into oVirt:master Nov 15, 2021
nijinashok added a commit to nijinashok/ovirt-ansible-collection that referenced this pull request Nov 23, 2021
…Virt#382)

There are possiblities that the vdsm might be holding the LUN
temporarily while we run "multipath -f". In these cases, the flushing
fails with error "map in use". Retry multipath -f (6 * 5 seconds) to
workaround this race condition.
mnecas pushed a commit that referenced this pull request Nov 23, 2021
…382) (#389)

There are possiblities that the vdsm might be holding the LUN
temporarily while we run "multipath -f". In these cases, the flushing
fails with error "map in use". Retry multipath -f (6 * 5 seconds) to
workaround this race condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants