ovirt_remove_stale_lun: Use add_host instead of delegate_to #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
nijinashok
force-pushed
the
master
branch
2 times, most recently
from
2b573e7 to
8ef61e9
Compare
|
ci add to whitelist |
vjuranek
approved these changes
Nov 24, 2021
mnecas
requested changes
Nov 26, 2021
Using add_host has got several benefits: - Parallel execution of tasks in the discovered hosts. - Failure in one host doesn't affect the task execution in others. - Ansible gives more understandable summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we are using delegate_to using with_items to run the tasks in multiple hosts. This has got several problems:
Ansible considers tasks for all the hosts as single task since we are iterating over host_info using with_items to run it on multiple hosts. So if any of the tasks fails in any of the hosts, it stops the execution of the subsequent tasks on all other hosts. For example, if multipath -f fails on any hosts, it won't run the task for removing the SCSI device even for the hosts where it was able to remove the device from multipath successfully.
Each task is executed serially on the discovered hosts in DC because with_items unpacks serially.
It's very difficult to understand which host it got failed, and "PLAY RECAP" is not useful.
Using add_host automatically solves the above problems.