Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for custom disk alias for uploaded disk #121

Closed
aesteve-rh opened this issue Jul 29, 2022 · 1 comment · Fixed by #122
Closed

Add option for custom disk alias for uploaded disk #121

aesteve-rh opened this issue Jul 29, 2022 · 1 comment · Fixed by #122
Assignees
@aesteve-rh
Labels
enhancement Enhancing the system by adding new feature or improving performance or reliability good first issue Good issue for a new contributor
Milestone
ovirt-4.5.2

Comments

@aesteve-rh
Copy link
Member

ovirt-img upload-disk command assigns a fixed disk alias based on the source image name.

Add a command line option to allow adding custom disk aliases.
@aesteve-rh aesteve-rh added this to the ovirt-4.5.3 milestone Jul 29, 2022
@aesteve-rh aesteve-rh added enhancement Enhancing the system by adding new feature or improving performance or reliability good first issue Good issue for a new contributor labels Jul 30, 2022
@nirs
Copy link
Member

nirs commented Jul 31, 2022

This is very useful - changing iso disk name is not supported yet, so the only way to set the name is before the upload. It should be fixed in engine but it may not be easy. Adding an option is trivial.

Adding to 4.5.2 since this should be very easy.

@nirs nirs modified the milestones: ovirt-4.5.3, ovirt-4.5.2 Jul 31, 2022
aesteve-rh added a commit to aesteve-rh/ovirt-imageio that referenced this issue Aug 1, 2022
@aesteve-rh
ovirt-img: add name option for disk
35cf8d2 
Add '--name' option to the 'upload-disk' command
to allow users to define a custom alias name
for the new uploaded disk. If ommited, default
behaviour remains, taking the source image filename
as an alias.

usage: ovirt-img upload-disk [-h] [-c CONFIG] [--engine-url ENGINE_URL]
                             [--username USERNAME]
                             [--password-file PASSWORD_FILE] [--cafile CAFILE]
                             [--log-file LOG_FILE] [--log-level LOG_LEVEL]
                             [--max-workers MAX_WORKERS]
                             [--buffer-size BUFFER_SIZE] -s STORAGE_DOMAIN
                             [-f {raw,qcow2}] [--preallocated]
                             [--disk-id DISK_ID] [--name NAME]
                             filename
....
  --name NAME           Alias name for the new disk. If not specified, name
                        will correspond with the image filename.

Closes: oVirt#121
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh mentioned this issue Aug 1, 2022
Merged
@aesteve-rh aesteve-rh self-assigned this Aug 1, 2022
aesteve-rh added a commit to aesteve-rh/ovirt-imageio that referenced this issue Aug 1, 2022
@aesteve-rh
ovirt-img: add name option for disk
c293765 
Add '--name' option to the 'upload-disk' command
to allow users to define a custom alias name
for the new uploaded disk. If ommited, default
behaviour remains, taking the source image filename
as an alias.

usage: ovirt-img upload-disk [-h] [-c CONFIG] [--engine-url ENGINE_URL]
                             [--username USERNAME]
                             [--password-file PASSWORD_FILE] [--cafile CAFILE]
                             [--log-file LOG_FILE] [--log-level LOG_LEVEL]
                             [--max-workers MAX_WORKERS]
                             [--buffer-size BUFFER_SIZE] -s STORAGE_DOMAIN
                             [-f {raw,qcow2}] [--preallocated]
                             [--disk-id DISK_ID] [--name NAME]
                             filename
....
  --name NAME           Alias name for the new disk. If not specified, name
                        will correspond with the image filename.

Closes: oVirt#121
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@nirs nirs closed this as completed in #122 Aug 1, 2022
nirs pushed a commit that referenced this issue Aug 1, 2022
@aesteve-rh @nirs
ovirt-img: add name option for disk
c77a1ba 
Add '--name' option to the 'upload-disk' command
to allow users to define a custom alias name
for the new uploaded disk. If ommited, default
behaviour remains, taking the source image filename
as an alias.

usage: ovirt-img upload-disk [-h] [-c CONFIG] [--engine-url ENGINE_URL]
                             [--username USERNAME]
                             [--password-file PASSWORD_FILE] [--cafile CAFILE]
                             [--log-file LOG_FILE] [--log-level LOG_LEVEL]
                             [--max-workers MAX_WORKERS]
                             [--buffer-size BUFFER_SIZE] -s STORAGE_DOMAIN
                             [-f {raw,qcow2}] [--preallocated]
                             [--disk-id DISK_ID] [--name NAME]
                             filename
....
  --name NAME           Alias name for the new disk. If not specified, name
                        will correspond with the image filename.

Closes: #121
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aesteve-rh aesteve-rh

Labels
enhancement Enhancing the system by adding new feature or improving performance or reliability good first issue Good issue for a new contributor
Projects
None yet
Milestone
ovirt-4.5.2
Development

Successfully merging a pull request may close this issue.

ovirt-img: add name option for disk aesteve-rh/ovirt-imageio
2 participants
@nirs @aesteve-rh