ovirt-img: add name option for disk #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
added
the
enhancement
nirs
requested changes
Aug 1, 2022
Add '--name' option to the 'upload-disk' command
to allow users to define a custom alias name
for the new uploaded disk. If ommited, default
behaviour remains, taking the source image filename
as an alias.
usage: ovirt-img upload-disk [-h] [-c CONFIG] [--engine-url ENGINE_URL]
[--username USERNAME]
[--password-file PASSWORD_FILE] [--cafile CAFILE]
[--log-file LOG_FILE] [--log-level LOG_LEVEL]
[--max-workers MAX_WORKERS]
[--buffer-size BUFFER_SIZE] -s STORAGE_DOMAIN
[-f {raw,qcow2}] [--preallocated]
[--disk-id DISK_ID] [--name NAME]
filename
....
--name NAME Alias name for the new disk. If not specified, name
will correspond with the image filename.
Closes: oVirt#121
Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/ovirt-img-upload-disk-alias
branch
from
35cf8d2
to
c293765
Compare
nirs
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '--name' option to the 'upload-disk' command
to allow users to define a custom alias name
for the new uploaded disk. If ommited, default
behaviour remains, taking the source image filename
as an alias.
Closes: #121
Signed-off-by: Albert Esteve aesteve@redhat.com