This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-848] Optimize performance for Column2Row #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
FelixYBW
reviewed
May 14, 2022
native-sql-engine/cpp/src/operators/columnar_to_row_converter.cc
Outdated
Show resolved
Hide resolved
copperybean
reviewed
May 26, 2022
| const std::vector<int64_t>& GetOffsets() { return offsets_; } | ||
| const std::vector<int64_t>& GetLengths() { return lengths_; } | ||
| const std::vector<int32_t>& GetOffsets() { return offsets_; } | ||
| const std::vector<int32_t, boost::alignment::aligned_allocator<int32_t, 32>>& |
There was a problem hiding this comment.
I think the second template parameter with value 32 is misspelled.
boost::alignment::aligned_allocator<int32_t, 32>>
It should be 4?
There was a problem hiding this comment.
There was a problem hiding this comment.
It's used here for 256 bit aligned.
@zhixingheyi-tian here should be
_mm256_loada_si256not laodu
Yes, updated in #937.
Use _mm256_load_si256 instead of _mm256_loadu_si256.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimize C2R performance:
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)