This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-927] Implement AVX512 optimization selection in Runtime and merge two C2R code files into one. #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhixingheyi-tian
changed the title
|
cc @FelixYBW |
FelixYBW
suggested changes
May 26, 2022
| reminder_8x = _mm256_sub_epi32(x8_8x, reminder_8x); | ||
| reminder_8x = _mm256_and_si256(reminder_8x, x7_8x); | ||
| reminder_8x = _mm256_add_epi32(reminder_8x, length_8x); | ||
| __m256i dst_length_8x = _mm256_loadu_si256((__m256i*)length_data); |
There was a problem hiding this comment.
Here should be aligned load since we allocate length_data as 32B aligned
| reminder_8x = _mm256_add_epi32(reminder_8x, length_8x); | ||
| __m256i dst_length_8x = _mm256_loadu_si256((__m256i*)length_data); | ||
| dst_length_8x = _mm256_add_epi32(dst_length_8x, reminder_8x); | ||
| _mm256_storeu_si256((__m256i*)length_data, dst_length_8x); |
There was a problem hiding this comment.
similarly, aligned store
| __m256i x8_8x = _mm256_load_si256((__m256i*)x_8); | ||
| __m256i offsetarray_1_8x; | ||
| if (j + 16 < num_rows_) { | ||
| offsetarray_1_8x = _mm256_loadu_si256((__m256i*)&offsetarray[j]); |
There was a problem hiding this comment.
Fill an issue here. by default arrow should always allocate 64Byte aligned buffer
This was referenced May 27, 2022
FelixYBW
approved these changes
May 27, 2022
|
can you fix the bencharm issue in this PR as well? |
zhixingheyi-tian
force-pushed
the
branch_runtime_avxselection
branch
3 times, most recently
from
a7d0a59 to
b5c261e
Compare
Have fixed in #936 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)