Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1789/Side by side authoring #2518

Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 23, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1789

Requires:

Summary

Add the side-by-side UI in the test authoring when translating.

image

Details

Add support for:

  • opening a test for translation: side-by-side UI

How to test

  • checkout the branch: git checkout -t origin/feature/ADF-1789/side-by-side-authoring
  • also make sure to checkout the companion PRs (feat/HKD-6/integration)
  • make sure to have the Feature Flags activated
FEATURE_FLAG_TRANSLATION_ENABLED=true
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER=true
  • make sure to have the Test Translator role assigned to your user
  • have a test ready for translation and add/edit a translation: it should present the side-by-side authoring
  • from a regular test, also open the authoring: it should present the usual authoring

@jsconan jsconan requested review from gabrielfs7 and shaveko October 23, 2024 14:26
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE part LGTM,

Thanks!

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, everything works as expected. Nice job!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@jsconan jsconan merged commit 000be2d into feat/HKD-6/integration Oct 30, 2024
@jsconan jsconan deleted the feature/ADF-1789/side-by-side-authoring branch October 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants