Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1782/Add styled datatable actions #603

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Sep 19, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1782

Summary

Add the possibility to style the action buttons from the datatable component.

Details

Each action may now be styled by setting a cls attribute in their descriptor.

Example:

$tableContainer.datatable({
    model: [ ... ],
    actions: [
        {
            id: 'label',
            label: 'Label',
            cls: 'btn-secondary',
            action() { ... }
        }
    ]
});

Copy link

Version

Target Version 3.8.0
Last version 3.7.0

There are 0 BREAKING CHANGE, 2 features, 0 fix

Copy link

Coverage Report

Totals Coverage
Statements: 76.88% ( 14349 / 18665 )
Methods: 80.23% ( 1814 / 2261 )
Lines: 81.39% ( 8590 / 10554 )
Branches: 67.44% ( 3945 / 5850 )

StandWithUkraine

@jsconan jsconan requested a review from shaveko September 23, 2024 06:04
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! :)

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jsconan jsconan merged commit d77bc34 into develop Sep 23, 2024
3 checks passed
@jsconan jsconan deleted the feature/ADF-1782/styled-datatable-actions branch September 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants