Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aut 3923/textreader image figure support #606

Merged
merged 4 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/figure/FigureStateActive.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export default function ({ stateFactory, ActiveState, formTpl, formElement, inli
const figurelem = this.widget.element;
const $texarea = this.widget.$form.find('textarea#figcaption');
texareaHTMLElem = $texarea[0];
texareaHTMLElem.style.minHeight = '2em';
function outputsize() {
figurelem.data('heigthCaptionInput', $texarea.height());
}
Expand Down
7 changes: 5 additions & 2 deletions src/mediaEditor/plugins/mediaAlignment/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,16 @@ export const positionFloat = function positionFloat(widget, position) {
if (!context.featureFlags['FEATURE_FLAG_DISABLE_FIGURE_WIDGET'] && prevClassName !== className) {
// Re-build Figure widget to toggle between inline/block
const parent = searchRecurse(widget.element.bdy.rootElement.bdy, widget.serial);
// avoid changes on Figure in a prompt
if (parent.contentModel && parent.contentModel === 'inlineStatic') {
// If Figure is not in A-block (Prompt, TextReader PCI)
if (parent.contentModel === 'inlineStatic' || widget.$container.closest('.qti-customInteraction').length) {
_.defer(() => {
widget.element.data('widget').refresh();
});
return;
}
// If Figure is in A-block, text is inside '<p>'. When'<figure>' is added inside, this '<p>' tag gets split and a linebreak appears.
// here we change state to sleep-active so that the user will see that reflected in UI immediately.
// otherwise, he will see this linebreak only if he focuses text in this A-block again, or reopens the item.
widget.element.data('widget').changeState('sleep');
_.defer(() => {
if (parent && parent.data('widget')) {
Expand Down
Loading