Fix/aut 3923/textreader image figure support #606
Conversation
Coverage Report
|
| const searchRecurse = (parentElement, serial) => { | ||
| if (!parentElement) { | ||
| return null; | ||
| } | ||
| if (parentElement.serial === serial) { | ||
| return parentElement; | ||
| } | ||
| let found = null; | ||
| _.some(parentElement['elements'], childElement => { | ||
| if (childElement.serial === serial) { | ||
| found = parentElement; | ||
| } else if (childElement['elements']) { | ||
| found = searchRecurse(childElement, serial); | ||
| } else if (childElement['prompt']) { | ||
| found = searchRecurse(childElement.prompt.bdy, serial); | ||
| } | ||
| if (found) { | ||
| return true; | ||
| } | ||
| }); | ||
| return found; | ||
| }; |
There was a problem hiding this comment.
Tagging @marpesia to see if she remembers something about the problem this code was added to solve 2 years ago.
There was a problem hiding this comment.
The code is working well on Authoring.
It rings a bell that it was done to be backwards compatible with previous items. This code was implemented at the end of 2022. Maybe it won't be an issue anymore.
I couldn't find any test exported from that time to validate my thoughts.
There was a problem hiding this comment.
I found the same code on itemqti. I think it is to replace any old item with the Figure tag. oat-sa/extension-tao-itemqti@ba70db0
Regarding the refresh() part, I remember we had some issues updating the CKEditor and keeping the changes.
There was a problem hiding this comment.
Thanks! I checked it again and found at least one difference: in A-block, when figure is added in the middle of text inside <p>, the content of <p> is split to mutliple lines ('<figure> is not allowed inside <p>? And Prompt or TextReader use <div> not <p>).
In my version, user wouldn't see that until he focuses text in A-block again, or reopens the item.
I'll restore old version, and add TextReader PCI check. Not sure how to check for A-block. As for contentModel, both A-block and TextReader have contentModel='itemBody'. And .qti-flow-container in GapMatch/Hottext doesn't have this issue.
There was a problem hiding this comment.
Regarding the A-block, I tested on oat-dev to see differences, and the behaviour is the same.
<Figure> is a block time, so it can't be inside a <p>.
I think it is ok.
olga-kulish
force-pushed
the
fix/AUT-3923/textreader-image-figure-support
branch
from
78326c9 to
3d48491
Compare
Version
There are 0 BREAKING CHANGE, 0 feature, 4 fixes |
Related to https://oat-sa.atlassian.net/browse/AUT-3923
Changes
mediaAlignment/helperIn TextReader PCI,
parent.contentModel && parent.contentModel === 'inlineStatic'didn't pass becauseparent.contentModelwas undefined. Becausewidget.refreshdidn't run, something wasn't updated, and image align reverted to Inline.It seemed fine to always call
widget.refreshinstead ofactive/sleep/activefor other cases (A-block, ChoiceInteraction choice), not only for Prompt. Only for prompts of MathEntry/Likert PCI, there was now "QTI XML compilation error" when there was<figure>in the prompt (figure wasn't allowed before, for same reason as in TextReader PCI), but it was solved by another change in Fix/aut 3923/textreader image figure support extension-tao-itemqti#2613This code was added in fix/AUT-2673/inline-figure-img #528, and
refreshwas added at the last moment.FigureStateActiveImage Caption textarea in Authoring side panel: it was completely collapsed for newly added images. Add some min-height to it. Image Caption textarea appears after you wrap inline image.
Test
On unit05. Related PRs: