Feat/aut 3675/add support to solar UI locales #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
pnal
reviewed
Jul 11, 2024
bartlomiejmarszal
requested changes
Jul 12, 2024
|
|
||
| namespace oat\tao\helpers\translation; | ||
|
|
||
| abstract class AbstractSolarThemeHelper |
There was a problem hiding this comment.
Abstract class without some implementation is useless. You may want to create interface instead
bartlomiejmarszal
approved these changes
Jul 12, 2024
Comment on lines
383
to
386
| private function isDirectory(string $path, array $localeDir): bool | ||
| { | ||
| return $localeDir[0] != '.' && @is_dir($path); | ||
| } |
There was a problem hiding this comment.
Suggested change
| private function isDirectory(string $path, array $localeDir): bool | |
| { | |
| return $localeDir[0] != '.' && @is_dir($path); | |
| } | |
| private function isDirectory(string $path, array $localeDir): bool | |
| { | |
| if (!isset($localeDir[0])) { | |
| return false; | |
| } | |
| if ($localeDir[0] == '.') { | |
| return false; | |
| } | |
| if (!is_dir($path)) { | |
| return false; | |
| } | |
| return true; | |
| } |
Karol-Stelmaczonek
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Feature/aut 3624/fix css solar UI
pribi
approved these changes
Jul 16, 2024
…-to-FE-Labels Feature/aut 3624/add translation to fe labels
Conflicts: views/css/tao-main-style.css views/css/tao-main-style.css.map views/js/lib/jsTree/themes/css/style.css.map views/js/loader/vendor.es5.min.js views/js/loader/vendor.es5.min.js.map views/js/loader/vendor.min.js.map
Conflicts: views/css/tao-main-style.css views/css/tao-main-style.css.map
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 11 features, 6 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/AUT-3675
Installation
Need to use tao-community with the June release
Then enable Solar theme https://oat-sa.atlassian.net/wiki/spaces/OAT/pages/2406350936/RFE-1147+Implementation+documentation
What to test
Summary
It makes translations with new prefix
Business logic
To create and update new local files:
// from Docker container php tao/scripts/taoTranslate.php -v -a=create -e=taoQtiItem -l=en-us```