Skip to content

Commit

Permalink
feat(#122): add one more puzzle
Browse files Browse the repository at this point in the history
  • Loading branch information
volodya-lombrozo committed Oct 3, 2023
1 parent 9054e2e commit 9a10b42
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ private static Object[] arguments(final Node node) {
* Convert hex string to human-readable string.
* @param hex Hex string.
* @return Human-readable string.
* @todo #122:90min Replace hexToString method with XmlData class.
* Right now we have some duplication among XmlInstruction and XmlData.
* They both implement the same logic of converting hex string to
* human-readable string. We should refactor this code and remove
* duplication.
*/
private static String hexToString(final String hex) {
return Arrays.stream(hex.split(" "))
Expand Down

2 comments on commit 9a10b42

@0pdd
Copy link

@0pdd 0pdd commented on 9a10b42 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 115-9420dbd7 disappeared from src/main/java/org/eolang/jeo/representation/asm/XmlBytecode.java), that's why I closed #122. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on 9a10b42 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 122-5d3c8d2c discovered in src/main/java/org/eolang/jeo/representation/asm/XmlInstruction.java) and submitted as #124. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.