Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlBytecode.java:34-37: Use BytecodeClass instead of ASM... #122

Closed
0pdd opened this issue Oct 3, 2023 · 2 comments · Fixed by #123
Closed

XmlBytecode.java:34-37: Use BytecodeClass instead of ASM... #122

0pdd opened this issue Oct 3, 2023 · 2 comments · Fixed by #123

Comments

@0pdd
Copy link

0pdd commented Oct 3, 2023

The puzzle 115-9420dbd7 from #115 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/asm/XmlBytecode.java

Lines 34 to 37 in a90b74a

* @todo #115:90min Use BytecodeClass instead of ASM library.
* Right now we are using ASM library to generate bytecode from XML.
* We should use BytecodeClass instead in order to reduce code duplication between
* XmlBytecode and BytecodeClass implementations.

The puzzle was created by volodya-lombrozo on 03-Oct-23.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Oct 3, 2023
@volodya-lombrozo
feat(#115): add one more puzzle for the XmlBytecode
a90b74a
This was referenced Oct 3, 2023
Closed
Closed
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 3, 2023
@volodya-lombrozo
feat(objectionary#122): use BytecodeClass instead of ASM ClassWriter
69af0ce
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 3, 2023
@volodya-lombrozo
feat(objectionary#122): simplify code in XmlBytecode
4adf595
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 3, 2023
@volodya-lombrozo
feat(objectionary#122): remove the puzzle for the objectionary#122 issue
9054e2e
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Oct 3, 2023
@volodya-lombrozo
feat(objectionary#122): add one more puzzle
9a10b42
@volodya-lombrozo volodya-lombrozo mentioned this issue Oct 3, 2023
Merged
@0pdd 0pdd mentioned this issue Oct 3, 2023
Closed
@0pdd
Copy link
Author

0pdd commented Oct 3, 2023

@0pdd the puzzle #124 is still not solved.

@0pdd
Copy link
Author

0pdd commented Oct 4, 2023

@0pdd the only puzzle #124 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#122): use BytecodeClass for bytecode generation from XML volodya-lombrozo/jeo-maven-plugin
1 participant
@0pdd