Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#122): use BytecodeClass for bytecode generation from XML #123

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Oct 3, 2023

Use BytecodeClass for bytecode generation from XML.

Closes: #122


History:


PR-Codex overview

Detailed summary

  • This PR focuses on refactoring code in the EoRepresentation and XmlInstruction classes.
  • It replaces the toByteArray method in EoRepresentation with a bytecode method.
  • It adds a new BytecodeClass class to handle bytecode generation.
  • It adds a new hexToString method in XmlInstruction and suggests replacing it with XmlData class to remove duplication.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 3, 2023

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9a10b42 into objectionary:master Oct 3, 2023
8 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 3, 2023

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XmlBytecode.java:34-37: Use BytecodeClass instead of ASM...
3 participants