-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#770): code() in OpcodeName.java for compatibility with opeo #771
Conversation
@volodya-lombrozo take a look, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel Thank you for the contribution! Only one small correction is needed.
.code(); | ||
MatcherAssert.assertThat( | ||
String.format( | ||
"Opcode code: %s does not matches with expected: %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel NIT: it's better to use %d
for numbers. Docs.
@volodya-lombrozo updated pull request. Take a look again, please |
@h1alexbel Looks good t me, thank you. |
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 8min). |
@volodya-lombrozo could you release a new version of JEO? |
In this pull I've added new method to
OpcodeName.java
:code()
. This method is required to be used by OPEO in order to resolve objectionary/opeo-maven-plugin#75.closes #770
History:
OpcodeName#code
for compatibility with opeo #770): opcodeOpcodeName#code
for compatibility with opeo #770): no emptyOpcodeName#code
for compatibility with opeo #770): puzzleOpcodeName#code
for compatibility with opeo #770): typoOpcodeName#code
for compatibility with opeo #770): shouldPR-Codex overview
This PR introduces a new method
code()
in theOpcodeName
class and adds a corresponding test inOpcodeNameTest
. The method retrieves the opcode value, and the test verifies its functionality.Detailed summary
code()
method inOpcodeName
.code()
method to return the opcode value.returnsOpcode()
inOpcodeNameTest
to validate thecode()
method's output.