feat(#770): code() in OpcodeName.java for compatibility with opeo #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volodya-lombrozo take a look, please |
volodya-lombrozo
requested changes
Oct 18, 2024
There was a problem hiding this comment.
@h1alexbel Thank you for the contribution! Only one small correction is needed.
| .code(); | ||
| MatcherAssert.assertThat( | ||
| String.format( | ||
| "Opcode code: %s does not matches with expected: %s", |
There was a problem hiding this comment.
@h1alexbel NIT: it's better to use %d for numbers. Docs.
|
@volodya-lombrozo updated pull request. Take a look again, please |
|
@h1alexbel Looks good t me, thank you. |
volodya-lombrozo
approved these changes
Oct 18, 2024
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 8min). |
|
@volodya-lombrozo could you release a new version of JEO? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull I've added new method to
OpcodeName.java:code(). This method is required to be used by OPEO in order to resolve objectionary/opeo-maven-plugin#75.closes #770
History:
OpcodeName#codefor compatibility with opeo #770): opcodeOpcodeName#codefor compatibility with opeo #770): no emptyOpcodeName#codefor compatibility with opeo #770): puzzleOpcodeName#codefor compatibility with opeo #770): typoOpcodeName#codefor compatibility with opeo #770): shouldPR-Codex overview
This PR introduces a new method
code()in theOpcodeNameclass and adds a corresponding test inOpcodeNameTest. The method retrieves the opcode value, and the test verifies its functionality.Detailed summary
code()method inOpcodeName.code()method to return the opcode value.returnsOpcode()inOpcodeNameTestto validate thecode()method's output.