Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpcodeName.java:37-39: Code duplication with... #75

Open
0pdd opened this issue Jan 15, 2024 · 12 comments · Fixed by objectionary/jeo-maven-plugin#771
Open

OpcodeName.java:37-39: Code duplication with... #75

0pdd opened this issue Jan 15, 2024 · 12 comments · Fixed by objectionary/jeo-maven-plugin#771
Assignees
Labels
enhancement New feature or request

Comments

@0pdd
Copy link

0pdd commented Jan 15, 2024

The puzzle 65-ca6c046e from #65 has to be resolved:

* @todo #65:30min Code duplication with jeo-maven-plugin.
* This class is a copy of org.eolang.jeo.representation.directives.OpcodeName.
* It should be moved to jeo-maven-plugin and used from there.

The puzzle was created by @rultor on 15-Jan-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@h1alexbel
Copy link
Contributor

@volodya-lombrozo can I take this one?

@volodya-lombrozo
Copy link
Member

@h1alexbel Sure, please, go ahead! This issue might be tricky, so don't hesitate to ask for help or explanation.

@h1alexbel
Copy link
Contributor

@volodya-lombrozo is it closed by mistake? The puzzle still in the source code

@h1alexbel
Copy link
Contributor

h1alexbel commented Oct 18, 2024

@volodya-lombrozo my bad actually. Looks like I referenced in pull request description here: objectionary/jeo-maven-plugin#771 (comment). We should reopen this

@h1alexbel
Copy link
Contributor

@volodya-lombrozo after we released 0.6.7, and 0.6.8. In OPEO, we don't have two classes that was imported from JEO 0.5.7: org.eolang.jeo.representation.directives.DirectivesData, org.eolang.jeo.representation.xmir.HexString. I will checkout their implementation in 0.5.7 JEO release, and try to inline them somehow into required classes, without a need to introduce new classes. WDYT?

@volodya-lombrozo
Copy link
Member

@h1alexbel Oh, sorry, I missed that as well. Reopen it.

@volodya-lombrozo
Copy link
Member

@h1alexbel We significantly changed the jeo-maven-plugin and current implementation of the opeo-maven-plugin is extremely outdated. Maybe it's better to update opeo-maven-plugin according with these changes first. Let's me do it. It might take a couple of days, I guess.

@volodya-lombrozo
Copy link
Member

@h1alexbel you can track the progress here.

@h1alexbel
Copy link
Contributor

@volodya-lombrozo got it

@0crat
Copy link

0crat commented Oct 24, 2024

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus points - that's our team policy for accepted enhancements. Keep those great ideas coming! And hey, if you spot anything in the repo that doesn't look quite right, don't hold back - report those bugs too. Your keen eye helps us all improve!

@0pdd
Copy link
Author

0pdd commented Oct 24, 2024

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

1 similar comment
@0pdd
Copy link
Author

0pdd commented Oct 24, 2024

@0pdd Hey there, awesome job on that enhancement suggestion! 🎉 You've just snagged yourself 8 bonus ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants