Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unlint-non-existing-defect does not understand WPA lints #368

Open
h1alexbel opened this issue Feb 26, 2025 · 4 comments
Open

unlint-non-existing-defect does not understand WPA lints #368

h1alexbel opened this issue Feb 26, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@h1alexbel
Copy link
Contributor

h1alexbel commented Feb 26, 2025 •
edited
Loading

Imagine we have foo.eo:

+unlint unit-test-missing

# Foo.
[] > foo

foo.eo does not have a test file (foo-tests.eo). However, unlint-non-existing-defect says:

Unlinting rule 'unit-test-missing' doesn't make sense, since there are no defects with it (unlint-non-existing-defect)

unlint-non-existing-defect does not evaluate WPA lints to check whether if defect is valid or not, since now, it only evaluates Mono lints.
@h1alexbel
Copy link
Contributor Author

@yegor256 looks like a bug

@yegor256
Copy link
Member

@h1alexbel definitely

@yegor256 yegor256 added the bug Something isn't working label Feb 26, 2025
@h1alexbel
Copy link
Contributor Author

@yegor256 I will take this one

h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): test
da61115
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): wpa
9e5f4dc
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
feat(objectionary#368): clean
1f57755
@h1alexbel h1alexbel mentioned this issue Feb 27, 2025
Merged
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): explain
f090b5f
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): indentation
5720bc3
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): cache puzzle
f7e94a0
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): dedent
662c64a
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 27, 2025
@h1alexbel
bug(objectionary#368): clean indentation
15e564e
yegor256 added a commit that referenced this issue Feb 28, 2025
@yegor256
Merge pull request #369 from h1alexbel/368
dbbcfde 
bug(#368): `unlint-non-existing-defect` in WPA scope
@0pdd 0pdd mentioned this issue Feb 28, 2025
Open
@0pdd
Copy link

0pdd commented Feb 28, 2025

@h1alexbel the puzzle #372 is still not solved.

h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 28, 2025
@h1alexbel
bug(objectionary#368): disabled tests
c579224
@h1alexbel h1alexbel mentioned this issue Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @0pdd @h1alexbel