bug(#368): unlint-non-existing-defect in WPA scope

[h1alexbel]

In this pull I've introduced LtUnlintNonExistingDefectWpa to check +unlint meta for suppressions of non-existing defects in WPA scope.

ref #368
History:

• bug(unlint-non-existing-defect does not understand WPA lints #368): test
• bug(unlint-non-existing-defect does not understand WPA lints #368): wpa
• feat(unlint-non-existing-defect does not understand WPA lints #368): clean

[h1alexbel]

@maxonfjvipon please check

[maxonfjvipon]

@h1alexbel can this line be move out of try catch scope? It seems that .defects does not throw IOException

[h1alexbel]

@maxonfjvipon Lint#defects() throws IOException:

lints/src/main/java/org/eolang/lints/Lint.java

Line 31 in 5acbb76

Collection<Defect> defects(T entity) throws IOException;

[maxonfjvipon]

@h1alexbel there's something wrong with indentation again. I think it can be fixed by unlint -> xml.path(

[maxonfjvipon]

@h1alexbel it also seems that during the entire project linting we call Lint.defect a several times and on each particular lint. And every time these defects are recalculated. Maybe we should introduce some kind of cache or wrap these lints with cache decorator? Or at least add todo?

[h1alexbel]

@maxonfjvipon updated. Take a look, please

[maxonfjvipon]

@h1alexbel something's still wrong with indentations

[h1alexbel]

@maxonfjvipon otherwise qulice complains about cascade indentation

[maxonfjvipon]

@h1alexbel how about this:

.forEach(
    unlint -> xml.path(
        String.format(
            "program/metas/meta[head='unlint' and tail='%s']/@line", unlint
        )
    )
    .map(xnav -> xnav.text().get())
    .collect(Collectors.toList())
    .forEach(
        line -> defects.add(
            new Defect.Default(
                this.name(),
                Severity.WARNING,
                xml.element("program")
                    .attribute("name")
                    .text()
                    .orElse("unknown"),
                Integer.parseInt(line),
                String.format(
                    "Unlinting rule '%s' doesn't make sense, since there are no defects with it",
                    unlint
                )
            )
        )
    )
)

[h1alexbel]

@maxonfjvipon only this one is valid (dedent with xml.path() args):

.forEach(
    unlint -> xml.path(
        String.format(
            "program/metas/meta[head='unlint' and tail='%s']/@line", unlint
        )
        )
        .map(xnav -> xnav.text().get())
        .collect(Collectors.toList())
        .forEach(
            line -> defects.add(
                new Defect.Default(
                    this.name(),
                    Severity.WARNING,
                    xml.element("program")
                        .attribute("name")
                        .text()
                        .orElse("unknown"),
                    Integer.parseInt(line),
                    String.format(
                        "Unlinting rule '%s' doesn't make sense, since there are no defects with it",
                        unlint
                    )
                )
            )
        )
);

[maxonfjvipon]

@h1alexbel this part looks ugly:

  )
  )

We definitely should find another way. How about this:

.forEach(
    unlint -> xml.path(
            String.format(
                "program/metas/meta[head='unlint' and tail='%s']/@line", unlint
            )
        )
        .map(xnav -> xnav.text().get())

[h1alexbel]

@maxonfjvipon the best we can do is this, I believe (since we cannot inline xml.path due to too wide line):

.forEach(
    unlint -> xml.path(
        String.format(
            "program/metas/meta[head='unlint' and tail='%s']/@line", unlint
        )
        )
        .map(xnav -> xnav.text().get())
        .collect(Collectors.toList())
        .forEach(
            line -> defects.add(
                new Defect.Default(
                    this.name(),
                    Severity.WARNING,
                    xml.element("program")
                        .attribute("name")
                        .text()
                        .orElse("unknown"),
                    Integer.parseInt(line),
                    String.format(
                        "Unlinting rule '%s' doesn't make sense, since there are no defects with it",
                        unlint
                    )
                )
            )
        )
);

WDYT?

[maxonfjvipon]

@h1alexbel what about this?

.forEach(
    unlint -> xml
        .path(
            String.format()
        )
        .map(...)
)

[h1alexbel]

@maxonfjvipon I think we did it. Big thanks!

[h1alexbel]

@yegor256 take a look, please

[yegor256]

@h1alexbel cool, thanks