-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove peerDependencies from package.json #76
Comments
This is a pain point for the whole RN community. At some point I heard they were going to stop releasing RC:s, but obviously that didn't happen. It wouldn't be such a big problem unless everybody wanted to jump the gun to use pre-release versions in their apps. The peerDependency list actually means anything that's 0.4 or newer is OK in addition to all the prereleases listed. So if you're using a stable version or RN like 0.16.0 it's not this package stopping you, and I can confirm I'm currently using it with said version without problems. That said I'm inclined to agree that it's time to be pragmatic, save me some work every other week and remove it. |
@oblador Thanks man, I appreciate it! |
Usually causes more problems than it solves and others have been removing it, too: - oblador/react-native-vector-icons#76 - Yomguithereal/baobab-react#59 - react-native-device-info/react-native-device-info#16
Usually causes more problems than it solves and others have been removing it, too: - oblador/react-native-vector-icons#76 - Yomguithereal/baobab-react#59 - react-native-device-info/react-native-device-info#16
The current
peerDependencies
entry forpackage.json
reads:With that dependency list I am currently unable to install
react-native-vector-icons
withreact-native-carousel
andreact-native
version0.16.0
, because of npm/npm#8854.react-native-carousel
declares in itspackage.json
thesepeerDependencies
:The issue reported in npm/npm#8854 correctly complains about
0.16.0-rc
not being matched by>=0.4 <1.0
There is also #69, which asks for migrating from
peerDependencies
todependencies
. But I wonder: Is this dependency list necessary at all?What does the author of this package want to express with a dependency list that spells out every
rc
version ofreact-native
?My wild guesses:
0.16.0-rc
but not ok to use0.16.0
?0.18.0-rc
is not yet supported?react-native
may not work withreact-native-vector-icons
?It looks like
>=0.4.0
is the only meaningful requirement in this list and even that one can be dropped if you are willing to assume that nobody uses react-native versions before 4/20/2015 any longer.If you feel strongly about keeping this dependency list I kindly ask you to spell out every available react-native version that is supported by react-native-vector-icons, i.e.
...0.15.0-rc || 0.15.0 || 0.16.0-rc || 0.16.0 || 0.17.0-rc...
Or at least
0.16.0
. That's the version I need.Thank you in advance.
See also nick/react-native-carousel#29
The text was updated successfully, but these errors were encountered: