Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove peerDependencies from package.json #76

Closed
PublicParadise opened this issue Dec 18, 2015 · 2 comments
Closed

Please remove peerDependencies from package.json #76

PublicParadise opened this issue Dec 18, 2015 · 2 comments

Comments

@PublicParadise
Copy link

The current peerDependencies entry for package.json reads:

"peerDependencies": {
    "react-native": ">=0.4.0 || 0.5.0-rc1 || 0.6.0-rc || 0.7.0-rc || 0.7.0-rc.2 || 0.8.0-rc || 0.8.0-rc.2 || 0.9.0-rc || 0.10.0-rc || 0.11.0-rc || 0.12.0-rc || 0.13.0-rc || 0.14.0-rc || 0.15.0-rc || 0.16.0-rc || 0.17.0-rc"
  },

With that dependency list I am currently unable to install react-native-vector-icons with react-native-carousel and react-native version 0.16.0, because of npm/npm#8854.
react-native-carousel declares in its package.json these peerDependencies:

"peerDependencies": {
    "react-native": ">=0.4 <1.0"
  }

The issue reported in npm/npm#8854 correctly complains about 0.16.0-rc not being matched by >=0.4 <1.0

There is also #69, which asks for migrating from peerDependencies to dependencies. But I wonder: Is this dependency list necessary at all?
What does the author of this package want to express with a dependency list that spells out every rc version of react-native?

My wild guesses:

  • that it is ok to use react-native 0.16.0-rc but not ok to use 0.16.0?
  • that 0.18.0-rc is not yet supported?
  • that future versions of react-native may not work with react-native-vector-icons?

It looks like >=0.4.0 is the only meaningful requirement in this list and even that one can be dropped if you are willing to assume that nobody uses react-native versions before 4/20/2015 any longer.
If you feel strongly about keeping this dependency list I kindly ask you to spell out every available react-native version that is supported by react-native-vector-icons, i.e.
...0.15.0-rc || 0.15.0 || 0.16.0-rc || 0.16.0 || 0.17.0-rc...

Or at least 0.16.0. That's the version I need.
Thank you in advance.

See also nick/react-native-carousel#29

@oblador
Copy link
Owner

oblador commented Dec 19, 2015

This is a pain point for the whole RN community. At some point I heard they were going to stop releasing RC:s, but obviously that didn't happen. It wouldn't be such a big problem unless everybody wanted to jump the gun to use pre-release versions in their apps. The peerDependency list actually means anything that's 0.4 or newer is OK in addition to all the prereleases listed. So if you're using a stable version or RN like 0.16.0 it's not this package stopping you, and I can confirm I'm currently using it with said version without problems.

That said I'm inclined to agree that it's time to be pragmatic, save me some work every other week and remove it.

@oblador oblador closed this as completed Dec 19, 2015
@PublicParadise
Copy link
Author

@oblador Thanks man, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants