Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from peerDependencies to dependencies #69

Closed
wants to merge 1 commit into from

Conversation

Kureev
Copy link
Contributor

@Kureev Kureev commented Dec 11, 2015

With npm v3+ and it's flat dependencies structure there are no reasons to keep using peerDependencies any more.

Besides this, peerDependency's errors are really annoying:
image

@oblador
Copy link
Owner

oblador commented Dec 11, 2015

I think it's premature to require npm3 since it's still quite buggy at least with react native. Doing this with npm2 will get you two react-native folders that will cause packager errors. The solution I see now is to remove it alltogether.

@Kureev
Copy link
Contributor Author

Kureev commented Dec 11, 2015

Hm, I haven't experienced any bugs with RN and npm3, but of course it's all up to you 😃. Also, npm3 has been officially released as "stable" (in npm blog you can find an article that node5 has shipped with npm3 by default).

P.S. They also mentioned peerDependencies here

@oblador
Copy link
Owner

oblador commented Dec 11, 2015

Yeah I'm keeping it open as we will get there eventually, but now is too soon imho. Reception of npm3 has been everything but great, it's super slow and breaks stuff so many just downgrade to npm2.

@satya164
Copy link
Contributor

If you specify specific versions of RN as a dependency what'll happen if people depend on a different version, like RC which isn't added to package.json yet, or people who use forked versions?

@oblador
Copy link
Owner

oblador commented Dec 19, 2015

@satya164: Yeah I don't think it's good idea right now to define react-native as a regular dependency. I've removed it completely now since the supported version range is so large and I'm assuming no-one is actually installing this package in isolation.

@satya164
Copy link
Contributor

@oblador Yup, right :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants