Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lucide icon #1702

Merged
merged 5 commits into from
Feb 2, 2025
Merged

feat: lucide icon #1702

merged 5 commits into from
Feb 2, 2025

Conversation

chanphiromsok
Copy link
Contributor

@chanphiromsok chanphiromsok commented Jan 15, 2025 •
edited
Loading

@chanphiromsok chanphiromsok changed the title feat: lucid icon feat: lucide icon Jan 16, 2025
@chanphiromsok
fix: switch from svg to use css and ttf instead
3a230b0 
- to fix icon  that fill the color in the circle
@chanphiromsok
Copy link
Contributor Author

@johnf Any chance to review this PR ?

@johnf johnf mentioned this pull request Jan 24, 2025
Closed
johnf
johnf requested changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@johnf johnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this it looks great!

Some minor changes requested.

Can you also add an entry to the README in the list of fonts?

packages/codemod/src/import-transform.ts Outdated Show resolved Hide resolved
packages/lucide/.yo-rc.json Outdated Show resolved Hide resolved
@chanphiromsok
fix: minor changes requested
3d5fa3c 
- use default postScriptName by ttf
- remove import lucide from import-transform.ts
- add font to readme
- bump lucide-static to  0.473.0
@chanphiromsok
Copy link
Contributor Author

Thanks for this it looks great!

Some minor changes requested.

Can you also add an entry to the README in the list of fonts?

@johnf please check my latest updated, TBH I am not clear add an entry to the README in the list of fonts?

@johnf
Copy link
Collaborator

johnf commented Feb 2, 2025 •
edited
Loading

@chanphiromsok I'm referring to the top level README which lists all the font packages https://github.com/oblador/react-native-vector-icons/blob/master/README.md#available-icon-sets

Which is done so maybe I missed it last time

@johnf
Update README.md
92b53b3 
missing italics markup
johnf
johnf reviewed Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@johnf johnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

johnf
johnf approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@johnf johnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@johnf johnf merged commit 9787881 into oblador:master Feb 2, 2025
4 of 16 checks passed
@chanphiromsok
Copy link
Contributor Author

@chanphiromsok I'm referring to the top level README which lists all the font packages https://github.com/oblador/react-native-vector-icons/blob/master/README.md#available-icon-sets

Which is done so maybe I missed it last time

I just added after you required it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnf johnf johnf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chanphiromsok @johnf