Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or improve labels #295

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Fix or improve labels #295

merged 5 commits into from
Oct 18, 2023

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Oct 13, 2023

If applied, this commit will fix #276 .

@rays22 rays22 self-assigned this Oct 13, 2023
@rays22 rays22 marked this pull request as draft October 13, 2023 15:25
@rays22 rays22 marked this pull request as ready for review October 13, 2023 15:50
ar-ibrahim
ar-ibrahim reviewed Oct 17, 2023
View reviewed changes
src/patterns/data/default/entity_attribute.tsv Outdated
OBA:2045272 cerebellum growth attribute UBERON:0002037 cerebellum PATO:0001492 growth rate https://orcid.org/0000-0001-8314-2140
OBA:2045273 cerebral cortex growth attribute UBERON:0000956 cerebral cortex PATO:0001492 growth rate https://orcid.org/0000-0001-8314-2140
OBA:2045274 prefrontal cortex growth attribute UBERON:0000451 prefrontal cortex PATO:0001492 growth rate https://orcid.org/0000-0001-8314-2140
OBA:2045270 basal ganglia growth characteristic UBERON:0002420 basal ganglion PATO:0001492 growth rate https://orcid.org/0000-0001-8314-2140
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rays22 Why were 'attribute' terms replaced by 'characteristic'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sound better. It was suggested by James at the meeting last Friday.

matentzn
matentzn reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would ask in OBO channel what people think of the changing "X attribute" labels to "X characteristic" labels. This gives @cmungall and @dosumis a chance to but in (this is not a minor change)

@rays22
Copy link
Contributor Author

rays22 commented Oct 17, 2023

LGTM but I would ask in OBO channel what people think of the changing "X attribute" labels to "X characteristic" labels. This gives @cmungall and @dosumis a chance to but in (this is not a minor change)

I am open to suggestions and input on the labels, but I am not sure if this label change is a major change. I would think that attribute and characteristic are synonyms.:

@matentzn
Copy link
Contributor

Its also about branding. better safe than sorry

@jamesamcl
Copy link
Collaborator

Maybe some polling required. I feel that “characteristic” is a more commonly used word in the biology domain while “attribute” is more computer science - but I don’t have any data to back this up.

@rays22
Copy link
Contributor Author

rays22 commented Oct 18, 2023

I have reverted the characteristic in the labels to attribute. We can come back and change the labels in another PR, but now I want to merge this one, because it fixes some typos for a new OBA release.

@rays22 rays22 merged commit 41fd2d0 into master Oct 18, 2023
@rays22 rays22 deleted the issue276-3 branch October 18, 2023 10:13
@rays22 rays22 mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn left review comments

@ar-ibrahim ar-ibrahim ar-ibrahim left review comments

@jamesamcl jamesamcl Awaiting requested review from jamesamcl

Assignees

@rays22 rays22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map/curate 344 EFO measurement branch terms to OBA traits
4 participants
@rays22 @matentzn @jamesamcl @ar-ibrahim