Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new chemical level term #318

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Added new chemical level term #318

merged 3 commits into from
Apr 4, 2024

Conversation

ar-ibrahim
Copy link
Collaborator

@ar-ibrahim ar-ibrahim self-assigned this Feb 27, 2024
@rays22
Copy link
Contributor

rays22 commented Mar 15, 2024

Regarding the QC error (unsatisfiable class), I think the problem is that endocrine disruptor is a role, not a material entity in ChEBI. See BFO hierarchy.
To fix this, you need to use the chemical_role_attribute_location pattern.

@rays22 rays22 mentioned this pull request Mar 20, 2024
Open
@ar-ibrahim ar-ibrahim marked this pull request as ready for review April 4, 2024 13:30
@ar-ibrahim ar-ibrahim merged commit cee8a35 into master Apr 4, 2024
@ar-ibrahim ar-ibrahim deleted the new_term_chemical_level branch April 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rays22 rays22 rays22 approved these changes

Assignees

@ar-ibrahim ar-ibrahim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ar-ibrahim @rays22