-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logical definition photoreceptor update #2473
base: master
Are you sure you want to change the base?
Conversation
src/ontology/cl-edit.owl
Outdated
EquivalentClasses(obo:CL_0000210 ObjectIntersectionOf(obo:CL_0000540 ObjectSomeValuesFrom(obo:RO_0002215 obo:GO_0050962))) | ||
SubClassOf(Annotation(oboInOwl:is_inferred "true") obo:CL_0000210 obo:CL_0000006) | ||
EquivalentClasses(obo:CL_0000210 ObjectIntersectionOf(obo:CL_0000540 ObjectSomeValuesFrom(obo:RO_0002215 obo:GO_0050908))) | ||
SubClassOf(obo:CL_0000210 obo:CL_0008028) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change caused the inferred equivalence, which is not allowed and it's the reason the QC is failing. :)
2024-08-01 12:28:49,500 ERROR org.obolibrary.robot.ReasonOperation - Only equivalent classes that have been asserted are allowed. Inferred equivalencies are forbidden.
2024-08-01 12:28:49,502 ERROR org.obolibrary.robot.ReasonOperation - Equivalence: <http://purl.obolibrary.org/obo/CL_0000488> == <http://purl.obolibrary.org/obo/CL_0000210>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve the PR after Anita's changes resolved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
David said he fixed that in GO. We're waiting for a GO release and will update the imports then.
Fixed in GO. If we are using GO nightly release, will be fixed here if we update GO in this branch on Monday. |
@aleixpuigb could you work with @JABelfiore to update the GO import today? |
There isn't a new GO release. The last one was from June. We don't use the GO nightly releases. |
New GO release on 2024-09-08, so update to GO should now fix. |
@aleixpuigb - could you update GO Import. Should fix. Thanks! |
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationseye photoreceptor cell
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsphotoreceptor cell
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
logical definition photoreceptor update and update text description to match