Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logical definition photoreceptor update #2473

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JABelfiore
Copy link
Collaborator

logical definition photoreceptor update and update text description to match

@JABelfiore JABelfiore self-assigned this Aug 1, 2024
@JABelfiore JABelfiore linked an issue Aug 1, 2024 that may be closed by this pull request
EquivalentClasses(obo:CL_0000210 ObjectIntersectionOf(obo:CL_0000540 ObjectSomeValuesFrom(obo:RO_0002215 obo:GO_0050962)))
SubClassOf(Annotation(oboInOwl:is_inferred "true") obo:CL_0000210 obo:CL_0000006)
EquivalentClasses(obo:CL_0000210 ObjectIntersectionOf(obo:CL_0000540 ObjectSomeValuesFrom(obo:RO_0002215 obo:GO_0050908)))
SubClassOf(obo:CL_0000210 obo:CL_0008028)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change caused the inferred equivalence, which is not allowed and it's the reason the QC is failing. :)

2024-08-01 12:28:49,500 ERROR org.obolibrary.robot.ReasonOperation - Only equivalent classes that have been asserted are allowed. Inferred equivalencies are forbidden.
2024-08-01 12:28:49,502 ERROR org.obolibrary.robot.ReasonOperation - Equivalence: <http://purl.obolibrary.org/obo/CL_0000488> == <http://purl.obolibrary.org/obo/CL_0000210>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve the PR after Anita's changes resolved :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David said he fixed that in GO. We're waiting for a GO release and will update the imports then.

@JABelfiore JABelfiore assigned dosumis and unassigned dosumis and JABelfiore Aug 2, 2024
@dosumis
Copy link
Contributor

dosumis commented Aug 2, 2024

Fixed in GO. If we are using GO nightly release, will be fixed here if we update GO in this branch on Monday.

@anitacaron anitacaron added the update-imports-required Imports need to be refreshed before this PR can be merged. label Aug 13, 2024
@dosumis
Copy link
Contributor

dosumis commented Sep 6, 2024

@aleixpuigb could you work with @JABelfiore to update the GO import today?

@anitacaron
Copy link
Contributor

There isn't a new GO release. The last one was from June. We don't use the GO nightly releases.

@dosumis
Copy link
Contributor

dosumis commented Sep 17, 2024

New GO release on 2024-09-08, so update to GO should now fix.

@dosumis
Copy link
Contributor

dosumis commented Sep 19, 2024

@aleixpuigb - could you update GO Import. Should fix. Thanks!

@aleixpuigb
Copy link
Collaborator

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-19/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-19/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

eye photoreceptor cell http://purl.obolibrary.org/obo/CL_0000287

Added

photoreceptor cell http://purl.obolibrary.org/obo/CL_0000210

Removed

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

photoreceptor cell http://purl.obolibrary.org/obo/CL_0000210

Removed

Added

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-imports-required Imports need to be refreshed before this PR can be merged.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Logical def] photoreceptor cell
5 participants