Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3056 Fix duplicate mappings #3126

Merged
merged 10 commits into from
Feb 20, 2024
Merged

3056 Fix duplicate mappings #3126

merged 10 commits into from
Feb 20, 2024

Conversation

gouttegd
Copy link
Collaborator

This is a first pass at fixing the duplicated cross-references highlighted in #3056.

We remove all duplicated cross-references (more than one Uberon term
pointing to a single foreign term) involving deprecated ontologies.
Remove most of the duplicated cross-references listed in issue #3056.

Not fixed here are all the EMAPA cross-references (will be done in a
separate commit given that there are quite a few of them) and a few
duplicated cross-references for which the "correct" resolution is
uncertain.
@gouttegd gouttegd self-assigned this Nov 23, 2023
@gouttegd gouttegd marked this pull request as ready for review December 18, 2023 20:45
@gouttegd
Copy link
Collaborator Author

Not sure what the heck is going on with the CI action on this PR… The workflow was seemingly triggered twice, one run terminated without problem, the other has been stuck with a “starting job” message for more than 90 minutes and there’s no way to cancel it…

@anitacaron
Copy link
Collaborator

I clicked on re-run workflow, and the one stuck disappeared.

@anitacaron
Copy link
Collaborator

I can't edit the filter in the complete list to check if everything conforms to it in this PR.

@gouttegd
Copy link
Collaborator Author

gouttegd commented Jan 3, 2024

@anitacaron Sorry, I didn’t know that one needed write access on a Google Calc spreadsheet merely to change the filters. I’ve cleared all the filters.

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me.

@gouttegd gouttegd merged commit 67d9f29 into master Feb 20, 2024
1 check passed
@gouttegd gouttegd deleted the 3056-fix-duplicate-mappings branch February 20, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants