Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the now deprecated relation "has dividend entity" from PATO #775

Closed
LarsVogt opened this issue Nov 24, 2023 · 6 comments · Fixed by #792
Closed

Adding the now deprecated relation "has dividend entity" from PATO #775

LarsVogt opened this issue Nov 24, 2023 · 6 comments · Fixed by #792
Assignees

Comments

@LarsVogt
Copy link

For new term requests, please provide the following information:

Preferred term label

has dividend entity

Synonyms

has dividend

Textual definition

A relationship between a ratio or proportion and its dividend.

Suggested parent term

RO

Attribution

https://orcid.org/0000-0002-8280-0487

@LarsVogt
Copy link
Author

This issue relates to the issue pato-ontology/pato#454 in PATO. Nico told me to ask @anitacaron for help adding this.

@nataled
Copy link
Collaborator

nataled commented Dec 4, 2023

Can have 'has numerator' as synonym, or maybe even primary label ('dividend' brings to mind payment from investments, in case we want to avoid that).

@ddooley
Copy link
Contributor

ddooley commented Dec 5, 2023

I'd second calling it "has numerator". No need for word "entity" esp as that makes it sound like a class of thing that has a dividend. Similarly for divisor -> "has denominator". Divisor/dividend sound like they are part of a division process; whereas ratios can be expressed as numerator/denominator. (Tho it seems they're all going out of style since 2010, related to math education?! https://books.google.com/ngrams/graph?content=divisor%2Cdividend%2Cnumerator%2Cdenominator&year_start=1900&year_end=2019&corpus=en-US-2019&smoothing=0)

@LarsVogt
Copy link
Author

LarsVogt commented Dec 5, 2023

"has numerator" and "has denominator" sound good. I am not a native speaker, so whatever labels you think fit best.

@rays22
Copy link
Contributor

rays22 commented Feb 21, 2024

This relationship would be relevant to model phenotypic traits, for example, the traits that represent the ratio of urinary sodium to potassium concentration in biological samples, or the waist circumference to height ratio.

Similar relationships are used to model ratio-related plant phenotypic traits and attributes, e.g.TO:0000278 root to shoot ratio :

  1. TO:has_dividend_quality
  2. TO:has_divisor_quality

Regarding the label or synonyms, both has numerator and has dividend look fine to me.

Maybe also add a new arithmetic relationship to group this and any related relationships.

@nataled
Copy link
Collaborator

nataled commented Feb 22, 2024

Interestingly, going through some old work of mine that didn't progress, I created a placeholder relation 'has numerator' (and its counterpart, 'has denominator'). Can we use these terms as the preferred label? I did a google search:

numerator denominator: 54 million hits
dividend divisor:       5.3 million hits

Looks like the world prefers those labels too :)

Applies to #774 also.

rays22 added a commit to rays22/obo-relations that referenced this issue Feb 26, 2024
rays22 added a commit to rays22/obo-relations that referenced this issue Feb 27, 2024
Discussed on RO call (2024-02-26):
* Add domain: Use PATO:0001470 "proportionality to", aka "ratio"
* Add as a subproperty of has-part
* Add range: PATO:quality (== COB:characteristic)

Resolve oborel#774
Resolve oborel#775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants