Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties has_numerator and has_denominator #792

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Feb 26, 2024

Fix #774
Fix #775

@cmungall
Copy link
Contributor

cmungall commented Feb 26, 2024

Discussed on RO call:

Domain:

  • Use PATO:0001470 "proportionality to", aka "ratio"
  • Add as a subproperty of has-part
  • range: PATO:quality (== COB:characteristic)

Discussed on RO call (2024-02-26):
* Add domain: Use PATO:0001470 "proportionality to", aka "ratio"
* Add as a subproperty of has-part
* Add range: PATO:quality (== COB:characteristic)

Resolve oborel#774
Resolve oborel#775
@rays22
Copy link
Contributor Author

rays22 commented Feb 27, 2024

Hi @anitacaron , would you be able to review this PR ? Thanks! 🙂

@anitacaron anitacaron merged commit 797a4e7 into oborel:master Feb 27, 2024
1 check passed
@anitacaron anitacaron mentioned this pull request Feb 27, 2024
@rays22 rays22 deleted the issue774 branch February 27, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants