Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022-07-19 Release #617

Merged
merged 4 commits into from
Jul 19, 2022
Merged

2022-07-19 Release #617

merged 4 commits into from
Jul 19, 2022

Conversation

anitacaron
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@shawntanzk shawntanzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an issue that ro.obo doesnt seem to have the OMO terms changes. ro-base.obo seems to have this though, so it feels a bit strange

@anitacaron
Copy link
Collaborator Author

I can see the OMO term in the ro.owl. Maybe something is wrong with obo conversion?

@shawntanzk
Copy link
Collaborator

it seems specific to ro.obo cause ro-base.obo has the axioms so its the specific conversion

@anitacaron
Copy link
Collaborator Author

I don't see the OMO addition in ro-base.obo

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -24,7 +24,7 @@ property_value: http://purl.org/dc/elements/1.1/description "The OBO Relations O
property_value: http://purl.org/dc/elements/1.1/title "OBO Relations Ontology" xsd:string
property_value: http://purl.org/dc/terms/license https://creativecommons.org/publicdomain/zero/1.0/
property_value: http://xmlns.com/foaf/0.1/homepage " https://github.com/oborel/obo-relations/" xsd:anyURI
property_value: owl:versionInfo "2022-05-23" xsd:string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally in git

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this in the ODK migration.

@shawntanzk
Copy link
Collaborator

Base wont have any OMO stuff, but ro.obo should. weird.

ironically ro-base.owl has it, but not ro.obo >.< lol

@anitacaron
Copy link
Collaborator Author

The OMO is in the base because it's inside edit and not via an import, as you said here, @matentzn: #615 (review)

The problem is with OBO conversion.

@anitacaron
Copy link
Collaborator Author

I can create the OMO import and rerun the release.

@anitacaron anitacaron changed the title 2022-07-18 Release 2022-07-19 Release Jul 19, 2022
@anitacaron
Copy link
Collaborator Author

After meeting with @matentzn, we're aware that OBO format doesn't show the new annotation and consequently the terms that are using the annotation. Please avoid using OBO artefact.

@shawntanzk
Copy link
Collaborator

After meeting with @matentzn, we're aware that OBO format doesn't show the new annotation and consequently the terms that are using the annotation. Please avoid using OBO artefact.

Is the plan then just to add that in release notes?

@shawntanzk
Copy link
Collaborator

also little bit confused about the OMO import - is this just jim not putting the new OMO terms in OMO yet and the import is plans for when it moves over?

@matentzn
Copy link
Contributor

I think the OBO artefact has been dropping a lot of stuff from RO anyways - it was always highly incomplete. It should just not be used at all, ideally we remove it, but I am not aware of anyone using it right now. We tried to understand why our specific expand annotation was removed (somehow a large portion of RO is in the owl-axioms header), but gave up. I don't think we need to add this to the release notes - this is not new at all, it was always like this.

OMO import is a placeholder for when we do the right thing with ODK.

@cmungall
Copy link
Contributor

cmungall commented Jul 19, 2022 via email

@matentzn
Copy link
Contributor

I made an issue here, but the issue only scratches the surface: #618

There are other things that do not happen to want to be released properly. What is super odd though: that the OMO stuff does not at least appear in the owl-axiom header. That is odd.

@anitacaron anitacaron merged commit a56b953 into master Jul 19, 2022
@cmungall
Copy link
Contributor

It looks like there is a separate issue with OMO that is totally unrelated to obo format - let's fix this first:

@anitacaron anitacaron deleted the 2022-07-18-release branch July 27, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants