facet requires the data to be specified #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It's a good point, sometimes I think our elegant little examples end up being harder to reuse (same with using k in the window examples). How about, "Facet specification requires a 'data' property"? |
mbostock
reviewed
Jun 13, 2022
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
approved these changes
Jun 13, 2022
eagereyes
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: is it explicit enough, given that a common error is people who see the pattern
{facet: {data, x: "category"} }and replacedatawith their own variable name, resulting in{facet: {data2, x: "category"} }?another wording might be
the values to facet must be specified as the data property, or something to that effect.