Skip to content

facet requires the data to be specified #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022
Merged

facet requires the data to be specified #938

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58ab333
facet requires the data to be specified
Fil Jun 13, 2022
2e15e49
wording
Fil Jun 13, 2022
195495a
Update src/plot.js
Fil Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export function plot(options = {}) {
const {x, y} = facet;
if (x != null || y != null) {
const facetData = arrayify(facet.data);
if (facetData == null) throw new Error("facet specification requires a data property");
facetChannels = {};
if (x != null) {
const fx = Channel(facetData, {value: x, scale: "fx"});
Expand Down