Add plugin: Instapaper

[jparise]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Instapaper/obsidian-instapaper

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[joethei]

id: 'instapaper-sync-notes',
Don't prefix the command id with the plugin id, that will happen internally automatically.

/ We delay the sync briefly to allow Obsidian time to finish loading;
use the following hook for that:

this.app.workspace.onLayoutReady(() => {
	// your code
});

import path from "path";
This import is available from a Node.js runtime, which means that this will throw errors on Mobile (that's a problem since you have isDesktopOnly marked as false in your manifest.json file.

path.join(folder, name + '.md')
Just join them with a normal slash /, in Obsidian all paths are using that format.

containerEl.createEl('h1', { text: 'Instapaper' });
Don't include a header with the plugin name in the settings

containerEl.createEl('h2', { text: 'Notes Sync' });
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

[jparise]

Thanks for the review! I've applied your feedback in Instapaper/obsidian-instapaper#21.

id: 'instapaper-sync-notes', Don't prefix the command id with the plugin id, that will happen internally automatically.

The Command interface includes this comment:

    /**
     * Globally unique ID to identify this command.
     * @public
     */
    id: string;

... so perhaps consider noting the plugin-level namespacing there (vs "globally unique")?